Refactor: remove unnecessery code, improve functionality, you can find a better solution for logic #4

					
				@ -13,4 +12,3 @@

				    sender.command(|out, shutdown| {

				        shutdown

				            .register(async move {

				                out.send(CmdOut::Progress {

better call out.emit, if we dont care with result

https://docs.rs/relm4/0.10.0/relm4/struct.Sender.html#method.emit

better call `out.emit`, if we dont care with result https://docs.rs/relm4/0.10.0/relm4/struct.Sender.html#method.emit

@ezozbek36 wrote in #4 (comment):

better call out.emit, if we dont care with result

https://docs.rs/relm4/0.10.0/relm4/struct.Sender.html#method.emit

but be careful with error cases. If you do out.send and this conroller dropped (UI closes this window) you may have not get error

@ezozbek36 wrote in https://git.oss.uzinfocom.uz/xinux/relago/pulls/4#issuecomment-186: > better call `out.emit`, if we dont care with result > > https://docs.rs/relm4/0.10.0/relm4/struct.Sender.html#method.emit but be careful with error cases. If you do out.send and this conroller dropped (UI closes this window) you may have not get error

lambdajon commented

2026-05-08 12:49:42 +00:00

let _ = action(); style This style is noisy, simple action(); style is better especially if it returns ()

`let _ = action();` style This style is noisy, simple `action();` style is better especially if it returns `()`

lambdajon requested changes

2026-05-08 13:15:01 +00:00

crates/gui/src/window/report.rs

					
				@ -14,3 +13,3 @@

				        shutdown

				            .register(async move {

				                out.send(CmdOut::Progress {

				                let _ = out.send(CmdOut::Progress {

There is no need for this.

ezozbek36 referenced this pull request

2026-05-08 13:48:41 +00:00

refactor: move d-bus listener into app lifecycle #3

Test CI / test-project (push) Has been cancelled

Details

Test CI / test-flake (push) Has been cancelled

Details

Test CI / test-project (pull_request) Has been cancelled

Details

Test CI / test-flake (pull_request) Has been cancelled

Details

This pull request has changes conflicting with the target branch.

crates/cli/src/lib.rs
crates/gui/src/window/report.rs

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Refactor: remove unnecessery code, improve functionality, you can find a better solution for logic' (#4) from refactors into main

Merge commit body

Reviewed-on: https://git.oss.uzinfocom.uz/xinux/relago/pulls/4

Merge pull request 'Refactor: remove unnecessery code, improve functionality, you can find a better solution for logic' (#4) from refactors into main

Reviewed-on: https://git.oss.uzinfocom.uz/xinux/relago/pulls/4