xinux/settings
10
0
Fork 0
Code Issues 24 Pull requests 4 Projects Releases Wiki Activity Actions

fix: app notification settings sync #19

Open
bemeritus wants to merge 18 commits from notificationpage-sync into main
pull from: notificationpage-sync
merge into: xinux:main
Conversation 11 Commits 18 Files changed 17 +1039 -774
bemeritus commented 2026-05-13 23:52:16 +00:00
Member
Copy link

Closes:

  • Notification app permission toggle logic not working: #10
  • Apps page code refactor: #2
  • Fix custom .desktop issue

Resource:

Additional changes:

## Closes: - [x] Notification app permission toggle logic not working: https://git.oss.uzinfocom.uz/xinux/settings/issues/10 - [x] Apps page code refactor: https://git.oss.uzinfocom.uz/xinux/settings/issues/2 - [x] Fix custom .desktop issue ## Resource: - https://gist.github.com/bahrom04/3edb8c765761c9e2aa9aeb54080dce5b ## Additional changes:
chore: add per-app notification GSettings reload support
All checks were successful
Test CI / flake-check (push) Successful in 13s
Details
Test CI / build (push) Successful in 2m30s
Details
Test CI / flake-check (pull_request) Successful in 10s
Details
Test CI / build (pull_request) Successful in 5s
Details
14512e3f32
bahrom04 reviewed 2026-05-14 10:07:41 +00:00
bahrom04 left a comment
Copy link

I have custom .desktop file. When i ran the app, I got warnings from these custom schemas:

(settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra 9' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as &

(settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra X' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as &
I have custom .desktop file. When i ran the app, I got warnings from these custom schemas: ``` (settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra 9' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as & (settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra X' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as & ```
chore: move save_app_bool function inside AppNotificationsPageModel
All checks were successful
Test CI / flake-check (push) Successful in 11s
Details
Test CI / build (push) Successful in 2m28s
Details
Test CI / flake-check (pull_request) Successful in 11s
Details
Test CI / build (pull_request) Successful in 5s
Details
b01557e32f
chore: Sync app details notification switch with GSettings
All checks were successful
Test CI / flake-check (push) Successful in 11s
Details
Test CI / build (push) Successful in 2m28s
Details
Test CI / flake-check (pull_request) Successful in 12s
Details
Test CI / build (pull_request) Successful in 6s
Details
c9ebd99443
bahrom04 commented 2026-05-18 14:14:48 +00:00
Owner
Copy link

related: #10

related: https://git.oss.uzinfocom.uz/xinux/settings/issues/10
bahrom04 commented 2026-05-19 10:11:56 +00:00
Owner
Copy link

@bemeritus please write what left to do on PR description

@bemeritus please write what left to do on PR description
chore: build app details page function moved to SimpleComponent
All checks were successful
Test CI / flake-check (push) Successful in 11s
Details
Test CI / build (push) Successful in 2m30s
Details
Test CI / flake-check (pull_request) Successful in 10s
Details
Test CI / build (pull_request) Successful in 6s
Details
a75e95ab30
bemeritus commented 2026-05-21 03:23:22 +00:00
Author
Member
Copy link

@bahrom04 check this pr

@bahrom04 check this pr
bahrom04 commented 2026-05-21 03:26:34 +00:00
Owner
Copy link

@bemeritus wrote in #19 (comment):

@bahrom04 check this pr

ok, before that please refactor import of crates. For example put all relm4 crates into on set like relm4::{gtk::, adw::}

@bemeritus wrote in https://git.oss.uzinfocom.uz/xinux/settings/pulls/19#issuecomment-786: > @bahrom04 check this pr ok, before that please refactor import of crates. For example put all relm4 crates into on set like relm4::{gtk::, adw::}
bahrom04 approved these changes 2026-05-21 03:31:26 +00:00
Dismissed
bahrom04 left a comment
Copy link

why not put these helper functions inside struct method?

why not put these helper functions inside struct method?
src/ui/apps/app_details_page.rs
@ -0,0 +169,4 @@
}
}
fn setup_notifications_row(app: &AppEntry, row: &adw::SwitchRow) {
bahrom04 commented 2026-05-21 03:27:50 +00:00
Owner
Copy link

why not put this into view macro too?

why not put this into view macro too?
bahrom04 marked this conversation as resolved
src/ui/apps/app_details_page.rs Outdated
@ -0,0 +208,4 @@
Some(app_settings_for_canonical(canonical_id))
}
fn show_app_details_dialog(app: &AppEntry, button: &gtk::Button) {
bahrom04 commented 2026-05-21 03:29:10 +00:00
Owner
Copy link

put this inside impl AppEntry {} then call function like self.show_app_details_dialog

put this inside impl AppEntry {} then call function like self.show_app_details_dialog
bahrom04 marked this conversation as resolved
bahrom04 requested changes 2026-05-21 03:31:45 +00:00
bahrom04 left a comment
Copy link

needs change

needs change
bahrom04 commented 2026-05-21 03:32:18 +00:00
Owner
Copy link

@bemeritus please write PR description what changes you did

@bemeritus please write PR description what changes you did
bahrom04 commented 2026-05-21 03:33:32 +00:00
Owner
Copy link

@bahrom04 wrote in #19 (comment):

I have custom .desktop file. When i ran the app, I got warnings from these custom schemas:

(settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra 9' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as &

(settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra X' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as &

what about this?

@bahrom04 wrote in https://git.oss.uzinfocom.uz/xinux/settings/pulls/19#issuecomment-382: > I have custom .desktop file. When i ran the app, I got warnings from these custom schemas: > > ```text > (settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra 9' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as & > > (settings:52969): Gtk-WARNING **: 14:54:15.205: Failed to set text 'Command & Conquer Generals Contra X' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as & > ``` what about this?
bahrom04 commented 2026-05-22 11:28:41 +00:00
Owner
Copy link

@bemeritus qoʻshimcha custon .desktop yasaganim: https://gist.github.com/bahrom04/3edb8c765761c9e2aa9aeb54080dce5b

@bemeritus qoʻshimcha custon .desktop yasaganim: https://gist.github.com/bahrom04/3edb8c765761c9e2aa9aeb54080dce5b
chore: put function to impl AppEntry
All checks were successful
Test CI / flake-check (push) Successful in 11s
Details
Test CI / build (push) Successful in 2m24s
Details
Test CI / flake-check (pull_request) Successful in 14s
Details
Test CI / build (pull_request) Successful in 7s
Details
29744984f9
chore: added use markup
Some checks failed
Test CI / flake-check (push) Has been cancelled
Details
Test CI / build (push) Has been cancelled
Details
Test CI / flake-check (pull_request) Has been cancelled
Details
Test CI / build (pull_request) Has been cancelled
Details
e56af48592 
take main brancha code
Revert "Merge remote-tracking branch 'origin' into notificationpage-sync"
All checks were successful
Test CI / flake-check (push) Successful in 12s
Details
Test CI / build (push) Successful in 3m3s
Details
Test CI / flake-check (pull_request) Successful in 9s
Details
Test CI / build (pull_request) Successful in 5s
Details
d9608dc958 
This reverts commit 896bf03820, reversing
changes made to e56af48592.
fix: hide Power Mode component when power profiles daemon is disabled
All checks were successful
Test CI / flake-check (pull_request) Successful in 9s
Details
Test CI / build (pull_request) Successful in 2m29s
Details
Test CI / flake-check (push) Successful in 9s
Details
Test CI / build (push) Successful in 5s
Details
7c4c959599
bahrom04 commented 2026-05-26 13:11:47 +00:00
Owner
Copy link

@bemeritus app On/Off boʻlgan yozuv yangilanmay qoldi

@bemeritus app On/Off boʻlgan yozuv yangilanmay qoldi
2026-05-26 18-10-39.mp4
32 MiB
All checks were successful
Test CI / flake-check (pull_request) Successful in 9s
Details
Test CI / build (pull_request) Successful in 2m29s
Details
Test CI / flake-check (push) Successful in 9s
Details
Test CI / build (push) Successful in 5s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin notificationpage-sync:notificationpage-sync
git switch notificationpage-sync
Sign in to join this conversation.
Reviewers
No reviewers
bahrom04
Labels
Clear labels
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fix
fixing good

  
good first issue

   
help wanted
Need some help

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
fix
good first issue
help wanted
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
xinux/settings!19
No description provided.